Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

requireArrowFunctions: only check for FunctionExpression as a callback? #1483

Closed
hzoo opened this issue Jun 24, 2015 · 0 comments
Closed

requireArrowFunctions: only check for FunctionExpression as a callback? #1483

hzoo opened this issue Jun 24, 2015 · 0 comments
Labels

Comments

@hzoo
Copy link
Member

hzoo commented Jun 24, 2015

Similar to #1413

So I think we can only warn when using FunctionExpression as a callback since in all the other cases we would have to do work to check for this/scope.

So in my next PR I would make an exception for node.parent.type === 'VariableDeclarator' or ReturnStatement

Or maybe since its only one case now it should somehow only check if it's a callback (!node.parent)?

hzoo added a commit to hzoo/node-jscs that referenced this issue Jun 26, 2015
hzoo added a commit to hzoo/node-jscs that referenced this issue Jun 27, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants