Improve error output #453
Comments
@markelog, for something like #238 it's easy to adapt the current error output simply number truncating the error array. However, the overall problem stems from the fact that most tools simply read the output of one of the error formats, all of which assume line and column. I'm not sure we can get away from reporting dropped rules in the normal error output without breaking the world. Thoughts? |
It's an easy way yes, but i was thinking that we need a correct message for it, if we would output say 100 errors when there could be a thousand, without any message, user would thought that we found only 100 errors in total, he would fix one, and still get a 100 errors, he would fix 10 and... you get the picture, whereas people might not look in doc for it, similar to a problem we have with nulling rules of the preset.
2.0 and break stuff, like in Limp Bizkit song |
But the default would be show all errors. Only by specifying a max would the user be seeing a possibly truncated list. But I get what you're saying. |
Are there any issues open or talks or plans for doing some sort of summarized report? I would love to be able to just get a general consensus of how my code is looking, without actually seeing the specifics. Something like: etc.. |
@SgtPooki These stats you talking about can be generated by custom reporter (afaik). Take a look at https://github.com/wurmr/jscs-teamcity-reporter |
@zxqfox Thanks but that reporter seems to output each error for each line for each file, the same as all other reporters. I did attempt to use that one before commenting here. It's output was quite ugly tbh. Would we just need to create an additional "summary" reporter, or is there a way to pass options to reporters? EDIT: Disregard, i'm going to write up a quick summary reporter.. it looks fairly simple. |
No time to submit it in a PR right this moment, but https://gist.github.com/SgtPooki/f13f24517b7a69b93017 |
@SgtPooki That's what I mean. Well done! 🌴 |
Wow, nice one. |
@SgtPooki could you send us a PR? |
I sure will. I will get it done tonight.. Finally got the wheel hub pried off my car last night, so tonight is free for a todo item of my choosing. I chose you. :) |
PR = #601 |
The reporter has been modified to add an additional table to report errors by rule type in the following format ┌──────────────────┬──────────────┬───────────────────┐ │ Rule │ Total Errors │ Files With Errors │ ├──────────────────┼──────────────┼───────────────────┤ │ disallowKeywords │ 1 │ 1 │ └──────────────────┴──────────────┴───────────────────┘ Fixes jscs-dev#453
Any updates on this? |
Recent release of
1.5.0
showed, on my opinion, that we need to improve error output, either provide warning module or adapt current error module API (rename maybe) to show notifications/warnings, without line and column number.Also this change is required for #238 issue, just like it might beneficial for plugins and rules notification.
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: