additionalRules not found since 1.8

[danez]

We have the problem, that since we updated to version 1.8 of jscs, our additional rules can not be found. Let me show an example.

We have this config in the root path of our project /project/.jscsrc:

{
    ...
    "additionalRules": ["projectRules/*.js"],
    "ourRule": true
}

Now when we do this everything works:

cd /project/
jscs src/path/something.js

But when we do this it fails with "Unsupported rule: ourRule":

cd /project/src
jscs path/something.js

If I change the config to "additionalRules": ["../projectRules/*.js"], it works again, so it seems to be an issue that the files specified in the config resolve with the cwd and not the path of the config file.

When going back to 1.7.x it works in both cases.

This also breaks it from being used in WebStorm/PHPStorm, as the IDE seems to call them always with the cwd set to the path of the file being checked.

[mikesherov]

Thanks for reporting! We'll look at this very soon! /cc @mdevils

[mdevils]

Going to work on this soon, thank you.

[lahmatiy]

Yep, after refactoring additionalRules doesn't accept file mask anymore, but expects Rule instances instead.
Before 1.8 adittionalRules processing by this code: https://github.com/jscs-dev/node-jscs/blob/v1.7.3/lib/options/additional-rules.js#L6-L9
And also test by this test suite https://github.com/jscs-dev/node-jscs/blob/v1.7.3/test/options/additional-rules.js