Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

Moves from the 'colors' package to 'chalk'. #1118

Closed
wants to merge 2 commits into from

Conversation

jbnicolai
Copy link
Contributor

See discussion in: #275

Contains:

  • b50244f Removes dependency on 'supports-color', now covered by 'chalk'.
  • 9c7c8c2 Replaces the 'colors' package with 'chalk'.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.93% when pulling b50244f on jbnicolai:switch-to-chalk into c9265a1 on jscs-dev:master.

@mrjoelkemp
Copy link
Member

Lgtm

@@ -66,8 +66,8 @@
"node": ">= 0.10.0"
},
"dependencies": {
"chalk": "^1.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We prefer tilde, can you please change that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed and --amended

@jbnicolai
Copy link
Contributor Author

Updated.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.93% when pulling ec00244 on jbnicolai:switch-to-chalk into c9265a1 on jscs-dev:master.

@jbnicolai
Copy link
Contributor Author

Anything I can do to get this merged? :)

@mikesherov
Copy link
Contributor

@jbnicolai, except wait patiently? ;-)

Just haven't had time to do a merge / test run. Will get to it shortly.

@jbnicolai
Copy link
Contributor Author

Heh, I'll stop nagging ;-)

@mikesherov mikesherov closed this in a9e7f09 Mar 2, 2015
@mikesherov
Copy link
Contributor

@jbnicolai , thanks again!

@jbnicolai
Copy link
Contributor Author

high five

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants