Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

add support for babel-jscs #1515

Closed
wants to merge 1 commit into from
Closed

add support for babel-jscs #1515

wants to merge 1 commit into from

Conversation

hzoo
Copy link
Member

@hzoo hzoo commented Jul 8, 2015

monkeypatch (specifically use of Module._resolveFilename) fails
on linux without symlink

removed monkeypatch method on babel-jscs and moved patching estraverse
to jscs itself.

Ref #1446

Pinning babel-jscs to PR to make it pass.

monkeypatch (specifically use of Module._resolveFilename) fails
on linux without symlink

removed monkeypatch method on babel-jscs and moved patching estraverse
to jscs itself.

Ref jscs-dev#1446
@hzoo
Copy link
Member Author

hzoo commented Jul 8, 2015

Ok wow it's all passing now - @markelog @zxqfox @mrjoelkemp

@markelog markelog closed this in 4d70439 Jul 8, 2015
@markelog
Copy link
Member

markelog commented Jul 8, 2015

Thank you @hzoo Hooray!

@hzoo
Copy link
Member Author

hzoo commented Jul 8, 2015

I can merge https://github.com/jscs-dev/babel-jscs/pull/10/files so we can change jscs-dev/babel-jscs#remove-monkeypatch. Would that be a major version so 2.0.0 or just 1.0.4?

@mrjoelkemp
Copy link
Member

It's a major bump since folks using babel-jscs will hit errors without the
latest jscs master since you removed the monkeypatch.
On Jul 8, 2015 8:28 AM, "Henry Zhu" notifications@github.com wrote:

I can merge https://github.com/jscs-dev/babel-jscs/pull/10/files so we
can change jscs-dev/babel-jscs#remove-monkeypatch. Would that be a major
version so 2.0.0 or just 1.0.4?


Reply to this email directly or view it on GitHub
#1515 (comment).

@hzoo
Copy link
Member Author

hzoo commented Jul 8, 2015

I was thinking that although I put in the readme to use master for jscs anyway since no release yet - ok thanks major then.

@hzoo
Copy link
Member Author

hzoo commented Jul 8, 2015

Also @markelog - can we update estraverse now?

https://github.com/jscs-dev/node-jscs/blob/master/lib/tree-iterator.js#L65 So when you remove add handler as well some tests fail.

We won't need https://github.com/jscs-dev/node-jscs/blob/master/lib/tree-iterator.js#L39-L49 since it would be covered in babel keys already. I don't know if we need the XJS ones since that's deprecated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants