This repository has been archived by the owner on Mar 23, 2024. It is now read-only.
Trailing whitespace fixes autofix, take 4 #1991
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really the trailing whitespace autofixer needs to be re-written - but in a few comments like #1981 (comment) people are against a simple way of doing it, preferring to instead modify tokens. It was also mentioned a few times that there will be large refactorings to fix in the CST. probably there needs to be a helper function that helps find whitespace in a way that trailing whitespace, dissallow tabs and validate end of line can all use.
Since the CST isn't available I have fixed comments on my patches to the original solution, doing the minimal amount of refactoring. I don't think this will hurt moving to the CST and the tests will be a useful addition in making sure any change is correct.