This repository has been archived by the owner on Mar 23, 2024. It is now read-only.
requirePaddingNewlinesBeforeKeywords: allow returning functions on same line
#1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adambullmer
force-pushed
the
fix-anonymous-return-padding
branch
from
9159804
to
f6fee9e
Compare
adambullmer
changed the title
requirePaddingNewlineBefore: allow returning functions on same linerequirePaddingNewlineBeforeKeyword: allow returning functions on same line
…same line
This adds an exception in the logic of the rule to allow returning an anonymous function.
```js
// valid
function func() {
var a = 0;
return function() {/*...*/}
}
```
adambullmer
changed the title
requirePaddingNewlineBeforeKeyword: allow returning functions on same linerequirePaddingNewlinesBeforeKeywords: allow returning functions on same line
adambullmer
force-pushed
the
fix-anonymous-return-padding
branch
from
f6fee9e
to
8c33d86
Compare
hzoo
pushed a commit
to hzoo/node-jscs
that referenced
this pull request
Jan 27, 2016
This adds an exception in the logic of the rule to
allow returning an anonymous function
```js
// valid
function func() {
var a = 0;
return function() {/*...*/}
}
```
Closes jscs-devgh-1997
hzoo
pushed a commit
to hzoo/node-jscs
that referenced
this pull request
Jan 27, 2016
This adds an exception in the logic of the rule to
allow returning an anonymous function
```js
// valid
function func() {
var a = 0;
return function() {/*...*/}
}
```
Closes jscs-devgh-1997
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When returning functions when not on the first line in the current scope, the style checker fails.
with the following config:
This adds an exception in the logic of the rule to allow returning an anonymous function.