This repository has been archived by the owner on Mar 23, 2024. It is now read-only.
requireCapitalizedConstructorsNew: New rule based on jshint newcap. #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new rule that behaves closer to the behavior of "newcap" in jshint. Fixes jscs-dev#2046
| describe('rules/require-capitalized-constructors-new', function() { | ||
| var checker; | ||
|
|
||
| function baseCases() { |
There was a problem hiding this comment.
Not sure if we need that, if tests covering used code-paths we good either way
There was a problem hiding this comment.
Meaning that we could move those tests from the helper function and to the 'with true value' describe
There was a problem hiding this comment.
So it's not necessary to run these tests on both the true and allExcept configurations? I based it on test/specs/rules/require-capitalized-constructors.js
There was a problem hiding this comment.
I'd say no, for my taste, if we covered it, it should be good
hzoo
pushed a commit
to hzoo/node-jscs
that referenced
this pull request
Jan 27, 2016
Valid var a = new B(); Invalid var d = E(); Added a new rule that behaves closer to the behavior of "newcap" in jshint Fixes jscs-dev#2046 Closes jscs-devgh-2047
hzoo
pushed a commit
to hzoo/node-jscs
that referenced
this pull request
Jan 27, 2016
Valid var a = new B(); Invalid var d = E(); Added a new rule that behaves closer to the behavior of "newcap" in jshint Fixes jscs-dev#2046 Closes jscs-devgh-2047
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new rule that behaves closer to the behavior of "newcap" in jshint.
Fixes #2046