Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

disallowQuotedKeysInObjects: fix Types and Values documentation #2053

Closed

Conversation

dharkness
Copy link
Contributor

  • Added Object to the list of Types
    Should String be removed since it's deprecated?
  • Fixed Values list formatting
    Was creating an extra indentation level

- Added Object to the list of Types
  Should String be removed since it's deprecated?

- Fixed Values list formatting
  Was creating an extra indentation level
@dharkness
Copy link
Contributor Author

  1. Should I remove deprecated types? (String in this case)
  2. Which style of listing three or more types do you prefer?
    • Boolean, String or Object (commas)
    • Boolean or String or Object (multiple "or"s)
  3. Any preference for ordering the types?
    • match the values list
    • alphabetical
    • some other strict ordering

@dharkness
Copy link
Contributor Author

From chat with @markelog

  1. No, leave deprecated types in the list
  2. Use the comma option (first)

@hzoo hzoo closed this in 0a921e9 Jan 8, 2016
@hzoo
Copy link
Member

hzoo commented Jan 8, 2016

Thanks!

hzoo pushed a commit to hzoo/node-jscs that referenced this pull request Jan 27, 2016
- Added Object to the list of Types
  Should String be removed since it's deprecated?

- Fixed Values list formatting
  Was creating an extra indentation level

Closes jscs-devgh-2053
hzoo pushed a commit to hzoo/node-jscs that referenced this pull request Jan 27, 2016
- Added Object to the list of Types
  Should String be removed since it's deprecated?

- Fixed Values list formatting
  Was creating an extra indentation level

Closes jscs-devgh-2053
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants