This repository has been archived by the owner on Mar 23, 2024. It is now read-only.
requireVarDeclFirst: Fixing an edge case #2061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this edge case the comments from previous block scope were being taken and a false positive error was thrown Fixes jscs-dev#2022 - issue
In this edge case the comments from previous block scope were being taken and a false positive error was thrown Fixes jscs-dev#2022 - issue
You need to add tests |
|
Oh I am so sorry for that. |
|
Totally okay, just bring it up |
In this edge case the comments from previous block scope were being taken and a false positive error was thrown Fixes jscs-dev#2022 - issue
|
Nicely done, thank you! |
hzoo
pushed a commit
to hzoo/node-jscs
that referenced
this pull request
Jan 27, 2016
In this edge case the comments from previous block scope were being taken and a false positive error was thrown Fixes jscs-dev#2022 Closes jscs-devgh-2061
hzoo
pushed a commit
to hzoo/node-jscs
that referenced
this pull request
Jan 27, 2016
In this edge case the comments from previous block scope were being taken and a false positive error was thrown Fixes jscs-dev#2022 Closes jscs-devgh-2061
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this edge case the comments from previous block scope were being taken and
a false positive error was thrown.
Fixes #2022 - issue