This repository has been archived by the owner on Mar 23, 2024. It is now read-only.
Allow array value for "safeContextKeyword" rule #225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) { | ||
| errors.add( | ||
| 'You should use "' + keyword + '" to safe "this"', | ||
| 'You should use "' + keywords.join('" or "') + '" to safe "this"', |
There was a problem hiding this comment.
can you improve this text while you're here touching this?
There was a problem hiding this comment.
safe "this" -> save a reference to "this"
Mike
On Tue, Feb 11, 2014 at 5:25 AM, Marat Dulin notifications@github.com
wrote:
) { errors.add(
'You should use "' + keyword + '" to safe "this"','You should use "' + keywords.join('" or "') + '" to safe "this"',Which text do you wish to get?
Reply to this email directly or view it on GitHub:
https://github.com/mdevils/node-jscs/pull/225/files#r9623212
|
This LGTM, can you just improve those warning message, and I can merge? |
|
👍 |
|
@markelog Can you please finish on this? 👍 |
|
What about the error message...? |
|
Shoot, will do |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this a way to go, but there you go.
Fixes #198
/cc @mdevils