This repository has been archived by the owner on Mar 23, 2024. It is now read-only.
Improve binary rules #379
Merged
Improve binary rules #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not return undefined return null instead, aligned with other token helper methods
This method will be helpful in future commits, meanwhile use it internally
Add optional backward argument and change default direction
|
💯 |
| it('should report assignment operator for "a=b"', function() { | ||
| checker.configure({ requireSpaceBeforeBinaryOperators: ['='] }); | ||
| assert(checker.checkString('a=b').getErrorCount() === 1); | ||
| }); | ||
| it('should not report assignment operator for "a = b" without option', function() { | ||
| checker.configure({ requireSpaceBeforeBinaryOperators: [','] }); | ||
| assert(checker.checkString('a= b').isEmpty()); | ||
| assert(checker.checkString('a=b').isEmpty()); |
There was a problem hiding this comment.
This doesn't seem to match the description
Add support and tests for all binary operators
Add support and tests for all binary operators
Add support and tests for all binary operators
Add support and tests for all binary operators
Add getPointerEntities method to token helper module, right now used only inside binary rules
@gustavohenke heads up, i think we could do |
|
Just a thought for this rule and other rules that have "giant arrays as values". Perhaps we should provide the |
+1 |
* Add binaryOperators attribute to utils module * Add true value as possible value to binary rules * Add one more test for binary rules to check true value * Update readme
|
@mikesherov done |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binary rules now support and has tests for all binary operators. Some of those tests are dynamically generated, but write them explicitly is tedious and needless.
After that we need to update presets, remove doc for
*stickedOperatorsrules and update the docs, then i think we would be ready for1.5.