This repository has been archived by the owner on Mar 23, 2024. It is now read-only.
Ignore maxErrors when NaN #687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 15, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, in some of the grunt-jscs tests,
maxErrorsoption was passed asNaN.This resulted in failure of the tests (because the error list was being cut to 0) and the delay
in releasing a new version depending in jscs@1.7.0.
I don't know if I should have invested more time in trying to fix this problem in grunt-jscs, but
right now is 3h12 AM here in Brazil, and I'm tired as hell :(
All I wanted to do is fix these errors so a new release of grunt-jscs could be made :D