Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

disallowDanglingUnderscores: deprecate exceptions and use an array inste... #725

Closed

Conversation

hzoo
Copy link
Member

@hzoo hzoo commented Oct 28, 2014

...ad

I just left in the exceptions to be backwards compatible.
So if you have an array, it includes the exceptions from before.
It makes sense to remove them too though.
#723

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) when pulling 57823a1 on hzoo:deprecreate-dangling-underscore-exceptions into d2206fd on jscs-dev:master.

@mrjoelkemp
Copy link
Member

Nice work @hzoo! I like that this doesn't break back-compat (which makes it a candidate for 1.8).

We should consider making this new value adhere to the new rule spec and use disallowDanglingUnderscores: { except: [] }

I also like having a default set of the most common exceptions as it would be redundant to exclude very common underscored properties.

FYI, perhaps __proto__ should be added?

Use new allExcept format and keep existing exceptions as the
default exceptions when `true` is used.
@hzoo hzoo force-pushed the deprecreate-dangling-underscore-exceptions branch from 57823a1 to 1000eb2 Compare October 28, 2014 12:07
@hzoo
Copy link
Member Author

hzoo commented Oct 28, 2014

Ok added in __proto__ and changed to disallowDanglingUnderscores: { allExcept: [] }

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) when pulling 1000eb2 on hzoo:deprecreate-dangling-underscore-exceptions into d2206fd on jscs-dev:master.

@mrjoelkemp
Copy link
Member

@hzoo nice job! Thanks for contributing.

mrjoelkemp pushed a commit to mrjoelkemp/node-jscs that referenced this pull request Oct 29, 2014
@hzoo hzoo deleted the deprecreate-dangling-underscore-exceptions branch October 29, 2014 01:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants