Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 add test-utils package #59

Closed
wants to merge 1 commit into from
Closed

🧪 add test-utils package #59

wants to merge 1 commit into from

Conversation

edbzn
Copy link
Member

@edbzn edbzn commented Nov 10, 2019

This is an attempt to fix module boundaries rule error from develop using a shared test-utils package. This approach comes with a problem. We can't use core exported things like HttpExtRequest type in test-utils and then use test-utils in core because it throws a circular dependency error.

@edbzn edbzn closed this Nov 12, 2019
@edbzn edbzn deleted the spike/test-utils branch November 12, 2019 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant