Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for search orders with empty string or null #20

Merged
merged 1 commit into from
Mar 10, 2018
Merged

Bugfix for search orders with empty string or null #20

merged 1 commit into from
Mar 10, 2018

Conversation

ermand
Copy link
Contributor

@ermand ermand commented Mar 10, 2018

Bugfix for search orders

If no string is providing in query string param, then send empty string to OrderRepository@searchOrder

@codecov
Copy link

codecov bot commented Mar 10, 2018

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #20   +/-   ##
=========================================
  Coverage     94.21%   94.21%           
  Complexity      436      436           
=========================================
  Files           107      107           
  Lines          1401     1401           
=========================================
  Hits           1320     1320           
  Misses           81       81
Impacted Files Coverage Δ Complexity Δ
.../Http/Controllers/Admin/Orders/OrderController.php 73.33% <100%> (ø) 7 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5118035...3bbae60. Read the comment docs.

@jsdecena
Copy link
Owner

thanks @ermand ! I can't believe I didn't have that test 😄 Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants