#70 Fix user address issues #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add cities and provinces to data to be sent to view
Add city and province select field to form data and used jquery select pluging to display the data.
Update view to return city name, province name and country name instead of the id's that was displayed.
Codecov Report
@@ Coverage Diff @@
## develop #71 +/- ##
=============================================
+ Coverage 89.94% 89.95% +0.01%
Complexity 554 554
=============================================
Files 125 125
Lines 1839 1842 +3
=============================================
+ Hits 1654 1657 +3
Misses 185 185
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix user address issues
Update form to contain city and province field so that the data saved can contain city_id and province_id to prevent breakages when order-address relationship is used.
NB:
City and Province can be properly implemented if loaded via jquery when the country is selected, and it loads the province that belongs to that country and also province to city. But this is just a minor fix to ensure no bug in this area.