-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"bootstrap" alias is gone in v1 #94
Comments
@MarkCarver thanks this is an oversite on my part - I'll have a fix up momentarily |
@MarkCarver the fix is deploying now - turns out the original |
Awesome :) Thanks for the quick turn around! Can I assume that in v2 this alias will be gone? |
It's up! http://api.jsdelivr.com/v1/bootstrap/libraries?name=bootstrap (you may need to hit the refresh button) - no worries, sorry about the mixup. That's a question for @jimaek, I'm okay w/ keeping it but I'd like to do so w/ proper code on the api-sync side (the little hack I just patched isn't the cleanest :) |
Fair enough. I have already gone and patched Drupal Bootstrap to use the real library name |
@MarkCarver Sorry for this issue, I hope it didnt severely impact your app. I will make sure this wont happen again @UnbounDev No need for hacks in |
I think this is related to the work in #69, but basically the folder alias that BootstrapCDN has is no longer in v1 of the API: http://api.jsdelivr.com/v1/bootstrap/libraries?name=bootstrap.
I understand this change is likely needed/wanted, but it should only have affected v2. This is technically a regression for v1 as it has affected existing code that relies on this alias provided in v1.
x-ref: https://www.drupal.org/node/2504343
The text was updated successfully, but these errors were encountered: