Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"bootstrap" alias is gone in v1 #94

Closed
markhalliwell opened this issue Jun 11, 2015 · 7 comments
Closed

"bootstrap" alias is gone in v1 #94

markhalliwell opened this issue Jun 11, 2015 · 7 comments
Assignees
Labels

Comments

@markhalliwell
Copy link

I think this is related to the work in #69, but basically the folder alias that BootstrapCDN has is no longer in v1 of the API: http://api.jsdelivr.com/v1/bootstrap/libraries?name=bootstrap.

I understand this change is likely needed/wanted, but it should only have affected v2. This is technically a regression for v1 as it has affected existing code that relies on this alias provided in v1.

x-ref: https://www.drupal.org/node/2504343

@markhalliwell
Copy link
Author

@UnbounDev UnbounDev self-assigned this Jun 11, 2015
@UnbounDev UnbounDev added the bug label Jun 11, 2015
@UnbounDev
Copy link
Contributor

@MarkCarver thanks this is an oversite on my part - I'll have a fix up momentarily

@UnbounDev
Copy link
Contributor

@MarkCarver the fix is deploying now - turns out the original twitter-bootstrap library was being aliased to bootstrap under the old sync structure, it didn't fit well, the patch I've just submitted should be through shortly.

@markhalliwell
Copy link
Author

Awesome :) Thanks for the quick turn around! Can I assume that in v2 this alias will be gone?

@UnbounDev
Copy link
Contributor

It's up! http://api.jsdelivr.com/v1/bootstrap/libraries?name=bootstrap (you may need to hit the refresh button) - no worries, sorry about the mixup.

That's a question for @jimaek, I'm okay w/ keeping it but I'd like to do so w/ proper code on the api-sync side (the little hack I just patched isn't the cleanest :)

@markhalliwell
Copy link
Author

Fair enough. I have already gone and patched Drupal Bootstrap to use the real library name twitter-bootstrap (just in case it does).

@jimaek
Copy link
Member

jimaek commented Jun 12, 2015

@MarkCarver Sorry for this issue, I hope it didnt severely impact your app. I will make sure this wont happen again

@UnbounDev No need for hacks in v2 its not backwards compatible. Lets make it clean and fast. Also be careful with v1, we cant break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants