New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New design feedback #14
Comments
@MartinKolarik @bebraw @megawac @pnommensen @tomByrer @as-com @GeorgeErickson |
My feedback for now:
|
For the image to left of library name can we use the person's GitHub profile photo? API via avatar_url https://developer.github.com/v3/users/. |
We can but I dont think it would be very pretty. |
Like the design overall, very pleasing |
|
Also |
Hi I'm designer :) Here is the answer to email from @jimaek Little keyboard by every link is actually "copy to clipboard" button. What do you say if we add another icon below download icon, that will stand for API? If yes, any idea how it could look? Feel free to write feedback. Cheers. |
This icon would be much better for copy to clipboard http://fontawesome.io/icon/files-o/ |
@kejnav |
@jimaek this is a better one imo http://fontawesome.io/icon/clipboard/ Also are we going to start using real paths ( |
@kejnav Yes, this is better http://fontawesome.io/icon/clipboard/ Thanks @megawac Paths and the backend will be discussed later. Right now we are working just on the design. HTML/CSS/JS/Backend all will come later. Right now we want to produce a final PSD |
I like the simple & distinct overall layout & scheme.
Agreed
Mark with icon or "mainfile" text next to the actual mainfile link, which should be listed first.
Switch to icon for that site.
Too much screen space used. Just an icon or number is fine. I don't want to scroll for pages looking for a repo that I have a fuzzy match on please. (I suffer from mild Repetitive strain injuries.) My observations:
Additions:
|
Also, is there a bottom & footer planned? I think the existing beta is fine: http://beta-jsdelivr-com.herokuapp.com/ |
You are right. @kejnav We will need to add a footer to the design. Dont forget that we plan adding lots of pages. And footer can list less important sponsors too I also agree on the point that too much space is wasted because of the stats. They could only appear when a user clicks on the project and opens its page. |
Yes, better all sponsors listed on bottom in smaller text, while lager icon-links near top for major sponsors. BTW @jimaek; plan to have a 'news item headline' &/or lattest twitter posts listed on the front page? Maybe a narrow banner on top? Like how CanIUse does it. |
@tomByrer I dont think twitter posts would be a good idea. We can simply add a link to our twitter account and thats it. |
atom.io has a really lovely theme if you're seeking inspiration. Maybe we can have trending libraries as well as a later feature? I'd also like to see github stars integration |
Sure, I was thinking of planning for it, then leave it out of final if not ready. |
Yeah, we could just use Github trending, powered by https://github.com/ricburton/trending http://githubtrending.herokuapp.com/trending?languages[]=javascript |
I think "API" is next to the link because it's API link. If the link goes away, so should that text.
I think the fact that it's always first and a little icon + tooltip are enough.
Yep.
I'd move the homepage icon to the left.
So do we have a page-per-project now? If so, I agree that we don't need stats in search results. What else is on project page? What about tags/labels? Do we want to remove these? I agree with @tomByrer that there should be a pagination like in beta and that there is too much vertical whitespace. |
Agreed; once people find the mainfile the first time, they'll easily find it again.
Right now a per-project page is the same as a normal view, but isolated results for only that item. Eg: http://www.jsdelivr.com/#!lodash |
Looking better, the |
@megawac Thank you. Actually that's the right place, tried to use that Google Material style http://material-design.storage.googleapis.com/images/materialdesign-goals-landingimage_large_xhdpi.png I can revisit that button if you don't like it :) |
@kejnav Can you try to see how the design looks like with some other projects? Some projects will have very long names and CDN links that will push your button and will make the page look a bit bad. And try the wizard with 10+ projects too, things might start breaking there I would prefer making the "mainfile" parameter more obvious like it is now but thats up to the rest of the guys. I trust the team :) |
Also, some projects have only one file. |
Some projects I would like to see rendered:
|
Sorry we're a picky folks @kejnav ;) @ALL: I'm thinking that long descriptions (like Ace) should either be not allowed or displayed fully. Over 2 sentences it begins to look like SEO or PR, not a 'description". |
I'm more partial to a shopping-cart analogy. Grab some stuff, get a total listing, then 'checkout', clearing your shopping cart. "My Collection" sounds like 'favorites' or bookmarking to follow. |
@kejnav does |
1st Old version of wizard, actually don't like it too much 2nd Various Description and Title length and one of these doesn't have github icon, I guess it looks totally fine. Also I wasn't able to do "show all" for that one that have lot of files because it's too much work in design process, but I guess that this one is really straight forward, if you click show all you'll have a bunch of links, there isn't some smart way to avoid that imo. 3rd New version of wizard. Really like the suggestion from @tomByrer |
@megawac This is design, so I don't know how to make it work 😄 |
Ha, okay anyway I'm digging it for the most part. The search bar looks a little squished. |
I think the second wizard is better. What happens if you click on the button? Popup? The coders will need ALL elements to code the HTML. This includes popup, open version dropdown, charts in the single project page. Thanks for the great designs! |
@jimaek NP If you're in a rush I can send you PSD of homepage just after I finish it, so developers could work on it. |
Nah, dont worry. Once we are 100% ready you can send the PSD with all the elements and pages |
@ALL I still don't like the "My Collection" analogy; not sure if it is for bookmarking, favorites, etc. I think we should list all the sponsors in the footer, even if we have to use normal-sized font. @kejnav Looking good. For testing, please use longest & shortest project names shuffled together in demos. |
@tomByrer Our deal with the sponsors was to keep them in the header. So their current positions are good. |
@jimaek As I suggested before:
You replied:
I replied:
So I was reminding the designer of prior conversation he missed. This thread is a mess; should have separate issues for separate items please. |
Work in Progress. This is NOT the final product and this is only the homepage.
Leave your feedback on what we should change and I will link the designer this issue.
The text was updated successfully, but these errors were encountered: