-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirm multi-core support with data per test #10
Comments
|
@zarianec It might make sense to run output parsers in worker threads, but I wouldn't worry about HTTP I/O, and ofc we don't have to worry about native commands since they run on separate processes already. |
Note to correctly handle native HTTP tests as well that dont call a binary jsdelivr/globalping#91 |
@jimaek as explained - it’s done |
Even HTTP (got)? |
HTTP is an I/O request - it’s asynchronous like web sockets are. It’s not recommended to run I/O requests on separate threads, since native aync mechanism is much more performant. I’ve also proven this on my benchmark test cases. |
@zarianec let us know what you think and if the task can be closed |
The probe server must utilize all available CPU cores.
Originally posted by @zarianec in jsdelivr/globalping#37 (comment)
Alternative by Patryk https://nodejs.org/docs/latest-v12.x/api/worker_threads.html
The text was updated successfully, but these errors were encountered: