Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prod API domain - Root / must show where to find docs #23

Closed
jimaek opened this issue Mar 17, 2022 · 7 comments · Fixed by #96
Closed

Prod API domain - Root / must show where to find docs #23

jimaek opened this issue Mar 17, 2022 · 7 comments · Fixed by #96
Assignees
Milestone

Comments

@jimaek
Copy link
Member

jimaek commented Mar 17, 2022

What should we use in prod?

  1. api.globalping.io (in this case root would just redirect to jsdelivr.com/globalping)
  2. globalping.jsdelivr.com
  3. other?

@zarianec @patrykcieszkowski please vote/comment

@zarianec
Copy link
Contributor

I vote for 1. Who knows what else we will need in the future (auth.globalping.io, registry.globalping.io, etc). It seems to be more flexible.

@patrykcieszkowski
Copy link
Contributor

From those two, definitely no. 1. @zarianec makes a good argument - it gives us more options to expand.

@jimaek
Copy link
Member Author

jimaek commented Mar 18, 2022

https://api.globalping.io/v1/probes is live. Lets update the default prod config too.

Also maybe *https://api.globalping.io/" could show a message explaining where to find the docs?

@zarianec
Copy link
Contributor

zarianec commented Mar 18, 2022

We can return a regular error with a proper message after implementing

@jimaek jimaek changed the title Prod API domain Prod API domain - Root / must show where to find docs Mar 20, 2022
@zarianec
Copy link
Contributor

This issue can be fixed now.

Also maybe *https://api.globalping.io/" could show a message explaining where to find the docs?

What docs URL we will use?

@jimaek
Copy link
Member Author

jimaek commented Mar 29, 2022

https://www.jsdelivr.com/globalping/docs was the idea. Unless we prefer to keep them GitHub hosted?

@zarianec
Copy link
Contributor

We decided to have it on GitHub for now. I guess it makes sense to keep this issue open until we have docs ready.

@jimaek jimaek mentioned this issue Apr 6, 2022
@jimaek jimaek assigned patrykcieszkowski and unassigned zarianec Apr 7, 2022
@jimaek jimaek added this to the Public Repo milestone Apr 18, 2022
@patrykcieszkowski patrykcieszkowski mentioned this issue Apr 20, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants