Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow private IPs for DNS tests #384

Closed
jimaek opened this issue Jul 3, 2023 · 5 comments · Fixed by jsdelivr/globalping-probe#164
Closed

Allow private IPs for DNS tests #384

jimaek opened this issue Jul 3, 2023 · 5 comments · Fixed by jsdelivr/globalping-probe#164
Assignees
@alexey-yarmosh

Comments

@jimaek
Copy link
Member

jimaek commented Jul 3, 2023

Let's allow the API to return tests with private IPs only in this case:

  • DNS test
  • Valid public hostname is used.

E.g.
broken.example.com -> 192.168.1.1 is ok
dev.home -> 192.168.1.1 is blocked like all other tests
@MartinKolarik
Copy link
Member

Many networking devices register themselves under public hostnames, e.g., Asus routers use router.asus.com, TP-Link uses tplinkwifi.net

@jimaek
Copy link
Member Author

jimaek commented Jul 3, 2023

I don't think it should be a problem knowing the IP of the router, it's visible as hop during traceroute anyway

@MartinKolarik
Copy link
Member

Hmm, it is, ok... and what's the use case here?

@jimaek
Copy link
Member Author

jimaek commented Jul 3, 2023

Misconfigured routing, e.g. DNS based CDN

@MartinKolarik
Copy link
Member

Ok.

@alexey-yarmosh alexey-yarmosh mentioned this issue Jul 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexey-yarmosh alexey-yarmosh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow private IPs for DNS tests jsdelivr/globalping-probe
3 participants
@jimaek @MartinKolarik @alexey-yarmosh