Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate IPs and hostnames #59

Closed
jimaek opened this issue Mar 29, 2022 · 3 comments · Fixed by #78
Closed

Validate IPs and hostnames #59

jimaek opened this issue Mar 29, 2022 · 3 comments · Fixed by #78
Assignees
Labels

Comments

@jimaek
Copy link
Member

jimaek commented Mar 29, 2022

It seems we try to ping IPs like 800.800.80.80 and we just get a measurement stuck in in-progress.
Same for hostnames like dfdf

Validate IPs and hostnames to make sure they are valid

@jimaek jimaek added the bug label Mar 29, 2022
@jimaek jimaek changed the title Validate IPs Validate IPs and hostnames Mar 29, 2022
@patrykcieszkowski
Copy link
Contributor

patrykcieszkowski commented Mar 29, 2022

is that really an issue? Worst case scenario it will just fail, the timeout will deal with the staus

@jimaek
Copy link
Member Author

jimaek commented Mar 29, 2022

It will fail after 30 seconds but its still a bad experience. We will take credits from the user for a failed test that we could have known that it will fail by simply running the input through some validation library.

@zarianec
Copy link
Contributor

I believe I even left a todo comment for that :) The issue with it is that this field accepts both up and hostnames so validation must apply to both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants