Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to select a file in grouping #436

Closed
irazasyed opened this issue Mar 9, 2014 · 3 comments
Closed

Add option to select a file in grouping #436

irazasyed opened this issue Mar 9, 2014 · 3 comments

Comments

@irazasyed
Copy link
Contributor

Hello,

I was trying the grouping feature today to save multiple calls (Very good stuff btw 馃憤)

And found there are 2 issues with this:

  1. Your system simply concatenates the main files without any knowledge of the type of file it is (CSS/JS). So if you load this link for example normalize,jquery you can see, it loaded CSS and JS both in one which won't obviously work (How is the browser supposed to understand and execute?). I do understand that's not how we're supposed to use the grouping feature and as per the README, it is only for JS but even though it is for JS, how can i access other JS files within a project while grouping (other than main file)? And it would be good if it can support CSS as well.
  2. Some libraries have CSS files with JS file as their mainfile and vice-versa. So if you want to group a lib's CSS file with other CSS files, it isn't working the way it is supposed to work (assuming it should have supported CSS as some projects mainfile is CSS) and instead it loads the mainfile (In this case it loads JS file) which i have already explained above. Here's the link which I'm trying to load in which i just want to group second project's CSS file along with the first one, but it simply loads the main JS file, hence it fails.

So it would be good to have some sort of option to select single file of a project to group with other files and support for CSS too.

Thanks!

@jimaek
Copy link
Member

jimaek commented Mar 9, 2014

  1. There is no way to load css and js in one call. Simply impossible. What you can do is to create 2 different URL groups. One for js and one for css files.
  2. Once this goes live you will be able to specify the files you need Allow Loading of Helpers in file-combiner聽#336 (comment)

@irazasyed
Copy link
Contributor Author

  1. I didn't mean i want to load css and js in one call, what i meant is it is currently loading which it is not supposed to do (See link above, it loaded both css and js which is wrong).
  2. This is exactly what i wanted and I'm already testing it, thanks!

@jimaek
Copy link
Member

jimaek commented Mar 10, 2014

  1. Oh I get it now. Yeah, I think there is no reason to limit it somehow. The user is free to do what he wants.
  2. Awesome :)

@jimaek jimaek closed this as completed Mar 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants