-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scroll to search results on the Hero Unit when the user stops typing #44
Comments
I don't like the debounce solution. I think it'd either feel too slow, or randomly jump down if you pause typing. @jimaek we might add the button which was in the original PSD files. I thought there was no use for it as the search is instant, but scrolling down on click might be a good idea. |
Well it wont solve the problem @abishekrsrikaanth is describing. Currently we already have the same solution with the enter. How about scrolling down the minute the user clicks inside the input field and automatically switch to the search input in the red nav menu? |
It would solve the problem that users don't know they need to hit enter. If the button were there, they'd most likely click it.
That should work as well. |
Issue:
Current when a library is searched on the Hero Unit on the index page, it scrolls to the result only when the enter key is pressed. The current website doesn't require the user to hit enter, so should the new website as the search results are retrieved as the user types in the textbox.
Workaround:
Setup a debounce of keypress to identify when the user stops typing and scroll to the search results.
Including @MartinKolarik as suggested by @jimaek
The text was updated successfully, but these errors were encountered: