Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting Types #2

Closed
wants to merge 4 commits into from
Closed

Exporting Types #2

wants to merge 4 commits into from

Conversation

dderjoel
Copy link

Those Changes will export the created Typings correctly so that import {Rule} from 'truegin' will no longer result in 'module not found' error.

Additionally, It will export the Alamanc Interface.
This might be used to have Callback-Types in when using the 'engine.on' function.

@dderjoel
Copy link
Author

dderjoel commented Jul 18, 2018

This is my first PR, I did not change any package-version number do I need to?

@dderjoel dderjoel mentioned this pull request Jul 18, 2018
@coveralls
Copy link

coveralls commented Jul 18, 2018

Pull Request Test Coverage Report for Build 15

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 96.1%

Totals Coverage Status
Change from base Build 12: 0.005%
Covered Lines: 465
Relevant Lines: 473

💛 - Coveralls

@jsdevtom
Copy link
Owner

Hi @dderjoel thank you for your pull request and you patience! As you haven't added or removed dependencies, please remove the commit locked package. Or was it necessary?

Also, I should have mentioned this in CONTRIBUTING.md, but you see how my previous commits follow a certain structure (refactor(engine): add return type to run()) for example? Its because commitizen is used to commit. Please use npm run commit instead of git commit. If you are unsure how to do this, I could try to amend your PR? 👍

@dderjoel
Copy link
Author

Yes, apparently it was necessary to commit package-lock.json because otherwise, the Travis-Build was not successful.
I have had a look into the CONTRIBUTING.mb, but it seemed outdated because it referenced /typescript-library-starter repo instead of truegin.
And Yes, please try to amend my PR. Next time I will use npm commit.

@jsdevtom jsdevtom mentioned this pull request Jul 23, 2018
@jsdevtom jsdevtom closed this Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants