Workaround for fileDependencies of SortableSet-type #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When webpack fileDependencies is of a `SortableSet`-type the `getFilesMtimes`-function returns a `TypeError: path must be a string or Buffer`-error. With this commit the function `getFilesMtimes` checks if the `file`-variable is a string before continuing the file-check.
adorum
suggested changes
Oct 12, 2018
| @@ -4,6 +4,10 @@ var async = require('async'); | |||
| function getFilesMtimes(files, concurrencyLimit, done) { | |||
| var filesMtimes = {}; | |||
| async.eachLimit(files, concurrencyLimit, function(file, fileDone) { | |||
| if (typeof file !== 'string') { | |||
| return fileDone(); | |||
There was a problem hiding this comment.
I think this breaks a whole logic a this plugin, bacause the dependencies updated times won't be stored in filesMtimes. I would rather convert the Set to an Array in index.js
// collect info about input dependencies to compilation
compiler.plugin('after-compile', function(compilation, afterCompileDone) {
// get updated mtimes of file dependencies of compilation
pluginContext.updateDependenciesMtimes(Array.from(compilation.fileDependencies), afterCompileDone);
});
vhadianto
added a commit
to vhadianto/only-if-changed-webpack-plugin
that referenced
this pull request
Feb 17, 2019
…#1) jsdf@2b48774 Slight modification from this fix: jsdf#7
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When webpack fileDependencies is of a
SortableSet-type thegetFilesMtimes-function returns aTypeError: path must be a string or Buffer-error.With this commit the function
getFilesMtimeschecks if thefile-variable is a string before continuing the file-check.