Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2D array @params support #14

Closed
qfox opened this issue Apr 22, 2015 · 5 comments
Closed

2D array @params support #14

qfox opened this issue Apr 22, 2015 · 5 comments
Assignees
@Kuniwak
Labels
bug
Milestone
v1.2.0

Comments

@qfox
Copy link
Contributor

qfox commented Apr 22, 2015 

/**
 * @param {number[][]} matrix
 */

Refs:
jsdoc/jsdoc#705
jscs-dev/jscs-jsdoc#94
@Kuniwak
Copy link
Member

Kuniwak commented Apr 23, 2015

Oops, it is a bug.
I'm working on #10, but the changes will break the backword compatibility.
I need time to implement a converter class for old style results.

@Kuniwak Kuniwak added the bug label Apr 23, 2015
@qfox qfox mentioned this issue May 4, 2015
Closed
@qfox
Copy link
Contributor Author

qfox commented May 4, 2015

@Kuniwak Hey there. Can I help you with that somehow?

@Kuniwak
Copy link
Member

Kuniwak commented May 7, 2015

@zxqfox
I apologize for worrying you.

I implemented the new parser, and now, I'm preparing publish v1.2.0-alpha and v2.0.0.

In v2.0.0, we can get new AST.
In v1.2.0, we can get results that is equivalent to v1.1.4, but it using the new parser and transform it to legacy.

@qfox
Copy link
Contributor Author

qfox commented May 7, 2015

Great work! Thank you!

Going to try it 😼

@Kuniwak Kuniwak added this to the v1.2.0 milestone May 10, 2015
@Kuniwak Kuniwak self-assigned this May 10, 2015
Kuniwak added a commit that referenced this issue May 11, 2015
@Kuniwak
Merge pull request #10 from Kuniwak/peg
5a814c9 
Use PEG to prevent bugs

Resolve #7 #9 #14
@Kuniwak
Copy link
Member

Kuniwak commented May 11, 2015

Resoved on #10.

@Kuniwak Kuniwak closed this as completed May 11, 2015
qfox pushed a commit to jscs-dev/jscs-jsdoc that referenced this issue May 11, 2015
Misc: bump jsdoctypeparser to use new PEG parser
8482622 
Fixes #94
Fixes #88
Ref jsdoctypeparser/jsdoctypeparser#14
Ref jsdoctypeparser/jsdoctypeparser#12
Ref jsdoctypeparser/jsdoctypeparser#7
Ref jsdoctypeparser/jsdoctypeparser#10
qfox pushed a commit to jscs-dev/jscs-jsdoc that referenced this issue May 11, 2015
Misc: bump jsdoctypeparser to use new PEG parser
cf2aff9 
Fixes #94
Fixes #88
Ref jsdoctypeparser/jsdoctypeparser#14
Ref jsdoctypeparser/jsdoctypeparser#12
Ref jsdoctypeparser/jsdoctypeparser#7
Ref jsdoctypeparser/jsdoctypeparser#10
jdlrobson pushed a commit to jdlrobson/jscs-jsdoc that referenced this issue Aug 21, 2015
@jdlrobson
Misc: bump jsdoctypeparser to use new PEG parser
534bba2 
Fixes jscs-dev#94
Fixes jscs-dev#88
Ref jsdoctypeparser/jsdoctypeparser#14
Ref jsdoctypeparser/jsdoctypeparser#12
Ref jsdoctypeparser/jsdoctypeparser#7
Ref jsdoctypeparser/jsdoctypeparser#10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kuniwak Kuniwak

Labels
bug
Projects
None yet
Milestone
v1.2.0
Development

No branches or pull requests
2 participants
@qfox @Kuniwak