Add support for numeric values passed to ‘border-spacing’, e.g. ‘border-spacing: 0’. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsiu
added a commit
to lsiu/CSSStyleDeclaration
that referenced
this pull request
Sep 27, 2017
…ng’, e.g. ‘border-spacing: 0’. Include test.
|
We use jsdom for some testing and some libraries we test with has border-spacing set to 0. |
|
I did another PR #52 which include a test and follow the same approach used in padding.js |
|
+1 for merging this, got the same error on jsdom. |
|
#52 does basically the same thing as this one + adds tests, so I'm +1 for merging either one of those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When providing
0toborder-spacing, cssstyle throws av.toLowerCase is not a functionerror.