Fix connectedCallback with document fragments

This regressed in 1f5acae. Closes #3290. Co-authored-by: Domenic Denicola <d@domenic.me>
jsdom · Nov 21, 2021 · 15cbed6 · 15cbed6
1 parent 79ff734
commit 15cbed6
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 1 deletion.
diff --git a/lib/jsdom/living/nodes/Node-impl.js b/lib/jsdom/living/nodes/Node-impl.js
@@ -838,7 +838,7 @@ class NodeImpl extends EventTargetImpl {
       this._descendantAdded(this, node);
 
       if (isConnected === undefined) {
-        isConnected = nodeImpl.isConnected;
+        isConnected = node.isConnected;
       }
 
       if (isConnected) {

diff --git a/test/web-platform-tests/to-upstream/custom-elements/connected-callbacks-template.html b/test/web-platform-tests/to-upstream/custom-elements/connected-callbacks-template.html
@@ -0,0 +1,33 @@
+<!DOCTYPE html>
+<meta charset="utf-8">
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<!-- Regression test for https://github.com/jsdom/jsdom/issues/3290 -->
+
+<body>
+<script>
+"use strict";
+
+test(() => {
+  let innerConnectedCallbackCalled = false;
+  customElements.define("inner-element", class extends HTMLElement {
+    connectedCallback() {
+      innerConnectedCallbackCalled = true;
+    }
+  });
+
+  let outerConnectedCallbackCalled = false;
+  customElements.define("outer-element", class extends HTMLElement {
+    connectedCallback() {
+      const template = document.createElement("template");
+      template.innerHTML = "<inner-element></inner-element>";
+      this.appendChild(document.importNode(template.content, true));
+      outerConnectedCallbackCalled = true;
+    }
+  });
+
+  document.body.appendChild(document.createElement("outer-element"));
+  assert_true(innerConnectedCallbackCalled, "inner connectedCallback must be called");
+  assert_true(outerConnectedCallbackCalled, "outer connectedCallback must be called");
+}, "Nested custom element connectedCallback insertion involving a template DocumentFragment");
+</script>