Merge pull request #527 from TomNomNom/master

Fixed bug where script passed to jsdom.env contains spaces
jsdom · Nov 5, 2012 · 40f0eb5 · 40f0eb5
2 parents d047be8 + da450d4
commit 40f0eb5
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/lib/jsdom/level2/html.js b/lib/jsdom/level2/html.js
@@ -143,7 +143,7 @@ core.resourceLoader = {
     request.end();
   },
   readFile: function(url, callback) {
-    fs.readFile(url.replace(/^file:\/\//, "").replace(/^\/([a-z]):\//i, '$1:/'), 'utf8', callback);
+    fs.readFile(url.replace(/^file:\/\//, "").replace(/^\/([a-z]):\//i, '$1:/').replace(/%20/g, ' '), 'utf8', callback);
   }
 };
 

diff --git a/test/level2/html.js b/test/level2/html.js
@@ -19796,5 +19796,16 @@ exports.tests = {
 
     delete String.prototype.normalize;
     test.done();
+  },
+
+  filename_with_spaces_in_script_tag_can_be_read: function(test) {
+    jsdom.env(
+      '<html><head></head><body></body></html>',
+      ['./html/files/js/script with spaces.js'],
+      function(err, window){
+        test.strictEqual(err, null, "There should be no errors when using scripts with spaces in their filenames");
+        test.done();
+      }
+    );
   }
 }
diff --git a/test/level2/html/files/js/script with spaces.js b/test/level2/html/files/js/script with spaces.js