Skip to content

Commit

Permalink
Raise minimum Node.js version to v18
Browse files Browse the repository at this point in the history
  • Loading branch information
domenic committed Nov 26, 2023
1 parent 032df9c commit 9b354af
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 15 deletions.
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
### Basic info:

- **Node.js version:** <!-- only v16 and above are supported -->
- **jsdom version:** <!-- only v22 and above are supported -->
- **Node.js version:** <!-- only v18 and above are supported -->
- **jsdom version:** <!-- only v23 and above are supported -->

### Minimal reproduction case

Expand Down
22 changes: 11 additions & 11 deletions .github/workflows/jsdom-ci.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: JSDOM-CI
name: CI

on:
push:
Expand All @@ -11,29 +11,29 @@ permissions:

jobs:
lint:
name: Lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: 'recursive'
- name: Run linter
uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: '20'
- name: Install dependencies
run: yarn --frozen-lockfile
- name: Run syntax rules check with ESLint
run: yarn lint
build-with-canvas:
name: Tests with node-canvas
env:
TEST_SUITE: 'node-canvas'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: 'recursive'
- name: Run Canvas tests with Node 18
uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: '20'
- name: Install required image manipulation packages with APT
Expand All @@ -45,20 +45,20 @@ jobs:
- name: Run tests
run: yarn add canvas && yarn test --retries 1
build:
name: Tests
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
node-version:
- 16
- 18
- 20
- latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: 'recursive'
- name: Run tests with Node ${{ matrix.node-version }}
uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- name: Setup HOSTS file for Web Platform Test server
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

jsdom is a pure-JavaScript implementation of many web standards, notably the WHATWG [DOM](https://dom.spec.whatwg.org/) and [HTML](https://html.spec.whatwg.org/multipage/) Standards, for use with Node.js. In general, the goal of the project is to emulate enough of a subset of a web browser to be useful for testing and scraping real-world web applications.

The latest versions of jsdom require Node.js v16 or newer. (Versions of jsdom below v22 still work with previous Node.js versions, but are unsupported.)
The latest versions of jsdom require Node.js v18 or newer. (Versions of jsdom below v23 still work with previous Node.js versions, but are unsupported.)

## Basic usage

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,6 @@
},
"main": "./lib/api.js",
"engines": {
"node": ">=16"
"node": ">=18"
}
}

0 comments on commit 9b354af

Please sign in to comment.