Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contextify is breaking jsdom on node v0.12.0 and io v1.1.0 #1022

Closed
MylesBorins opened this issue Feb 9, 2015 · 2 comments
Closed

Contextify is breaking jsdom on node v0.12.0 and io v1.1.0 #1022

MylesBorins opened this issue Feb 9, 2015 · 2 comments

Comments

@MylesBorins
Copy link

Appears to be the nan needs to be upgraded. There is already a PR in the queue.

brianmcd/contextify#154
@domenic
Copy link
Member

domenic commented Feb 9, 2015

Yes, this is a bug with contextify, not with jsdom.

@domenic domenic closed this as completed Feb 9, 2015
@MylesBorins
Copy link
Author

Posted here as the module cannot be installed currently on 0.12 or io.

Breaks any stack relying on it. Indeed the problem exists with contextify,
but I would argue that jsdom is broken as long as this dep causes the stack
to explode
On Feb 8, 2015 8:35 PM, "Domenic Denicola" notifications@github.com wrote:

Closed #1022 #1022.

—
Reply to this email directly or view it on GitHub
#1022 (comment).

@bebraw bebraw mentioned this issue Mar 6, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MylesBorins @domenic