Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with <style>/<link> processsing #2124

Open
3 of 6 tasks
domenic opened this issue Jan 24, 2018 · 1 comment
Open
3 of 6 tasks

Issues with <style>/<link> processsing #2124

domenic opened this issue Jan 24, 2018 · 1 comment
Labels
bug css

Comments

@domenic
Copy link
Member

domenic commented Jan 24, 2018 •
edited
Loading

From @TimothyGu's research in #2122 (comment), tracked here separately:

I'm working on an incoming PR to fix some, but not all of these.
domenic added a commit that referenced this issue Jan 24, 2018
@domenic
Fix <style>'s sheet property
d2957d5 
In particular, fixes #2122, where it was discovered that as of 8c84ebf we made the sheet null for empty <style> elements.

There are a lot more issues with this area of the codebase, as discovered in #2122 (comment). But we'll tackle them incrementally in #2124. This fixes one of them, about disconnected sheets, but leaves the ones having to do with <link> and @import and parsing alone for now.
domenic added a commit that referenced this issue Jan 24, 2018
@domenic
Fix <style>'s sheet property
a82793d 
In particular, fixes #2122, where it was discovered that as of 8c84ebf we made the sheet null for empty <style> elements.

There are a lot more issues with this area of the codebase, as discovered in #2122 (comment). But we'll tackle them incrementally in #2124. This fixes one of them, about disconnected sheets, but leaves the ones having to do with <link> and @import and parsing alone for now.
domenic added a commit that referenced this issue Jan 24, 2018
@domenic
Fix <style>'s sheet property
085dca4 
In particular, fixes #2122, where it was discovered that as of 8c84ebf we wrongly made the sheet null for empty <style> elements.

There are a lot more issues with this area of the codebase, as discovered in #2122 (comment). But we'll tackle them incrementally in #2124. This fixes one of them, about disconnected sheets, but leaves the ones having to do with <link> and @import and parsing alone for now.
@domenic domenic mentioned this issue Jan 24, 2018
Merged
domenic added a commit that referenced this issue Jan 25, 2018
@domenic
Fix <style>'s sheet property
0c54ed3 
In particular, fixes #2122, where it was discovered that as of 8c84ebf we wrongly made the sheet null for empty <style> elements.

There are a lot more issues with this area of the codebase, as discovered in #2122 (comment). But we'll tackle them incrementally in #2124. This fixes one of them, about disconnected sheets, but leaves the ones having to do with <link> and @import and parsing alone for now.
@Splaktar
Copy link

Any plans to fix the @import issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug css
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@domenic @Zirro @Splaktar