Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add customElements.getName() #3641

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add customElements.getName() #3641

wants to merge 1 commit into from

Conversation

mash-graz
Copy link

Fixes: #3640

@domenic
Copy link
Member

domenic commented Dec 23, 2023

This is missing tests. Fortunately, after 63265a9, you can probably follow the procedure outlined in https://github.com/jsdom/jsdom/blob/main/Contributing.md#web-platform-feature-tests to enable a preexisting test.

@mash-graz
Copy link
Author

mash-graz commented Dec 24, 2023 •
edited

Although I could find already existing tests for getName in unmerged WPT branches, I can't simply enable them, because they are not available in the main branch of the WPT upstream repo or here in the test directory.

see:

web-platform-tests/wpt@a644106#diff-308a795609efdc52e2aee7ccd0ee171e4e1bd72a034183c807f81ee6dbdb0d61

web-platform-tests/wpt#39640

@asamuzaK
Copy link
Contributor

It looks like file moved.
See Move CustomElementRegistry.getName() tests to a tentative test file · web-platform-tests/wpt@99ee1f5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing customElements.getName()
3 participants
@mash-graz @domenic @asamuzaK