Optimize the named property tracker by not walking the entire tree #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing if a named property can be untracked is now many times faster, which means `setAttribute()` and `removeChild()` will not be slowed by it. Looking up a named property will also be faster for huge documents
|
LGTM! No merge commits this time; --ff-only :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was one of the thing slowing down #1156 (w3c/respec#453).
The included benchmark has these results:
before:
jsdom x 0.19 ops/sec ±68.89% (5 runs sampled)after:
jsdom x 3,054 ops/sec ±7.63% (29 runs sampled)The named property tracker has been refactored by making the tracking and untracking more explicit. The tracker now keeps a list of potential values for a specific named property. The resolver function that is used for the
windowno longer walks the entire tree, but receives that list of potential values. It can then filter on that list and sort it in tree order usingcompareDocumentPosition. This works fast becausecompareDocumentPositionhas been optimized in #1169.