Travis browser builds are broken, only for PRs from forks I think #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, you killed it here: 28fd8b1#diff-354f30a63fb0907d4ad57269548329e3L23 They never actually worked, we just disabled browser tests for PRs on the command line. |
|
This should probably be |
Sebmaster
pushed a commit
that referenced
this pull request
Oct 22, 2015
Sebmaster
pushed a commit
that referenced
this pull request
Oct 22, 2015
|
Here we go, attached a commit which makes it work as expected for both PR + push scenarios. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to work :-/. Might need to disable them.