Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement of DOMParser #1519

Closed
wants to merge 1 commit into from

Conversation

kentcdodds
Copy link

Closes #1341
References #1368

@kentcdodds
Copy link
Author

This is still a WIP. I thought I should push this up to make sure I'm going in the right direction and get some feedback. The implementation is copied from @lehni's comment. Looks like it's incomplete. Feedback is welcome! Forgive me of my ignorance if some of what I have in here is obviously wrong. This is not an API I'm familiar with.

@Sebmaster
Copy link
Member

Sebmaster commented Jun 9, 2016

Try to find web-platform-tests which test the API instead of writing your own. If there's something not tested there, add them to the to-upstream folder instead (with the wpt format).

@lehni
Copy link
Contributor

lehni commented Jun 10, 2016

That's how we have it implemented as a work-around in paper.js currently: https://github.com/paperjs/paper.js/blob/develop/src/node/window.js#L58

It's definitely incomplete. I meant to work on this but have very little time to do so at the moment unfortunately.

@kentcdodds
Copy link
Author

I'm sorry everyone, I don't know if I'm going to get time to work on this again for a while. Someone else can feel free to pick up where I left off. :-/

@kentcdodds kentcdodds closed this Jun 14, 2016
@kentcdodds kentcdodds deleted the pr/support-domparser branch February 10, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants