Forms #1915
Open
Forms #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fairly minimal session history implementation. Next Step is to add some ability for SessionHistory to report when the `window` object has changed.
I’ve clearly identified which parts of the spec have not yet been implemented.
Including behaviour in whatwg/html#2796
This isn’t necessarily a very accurate implementation of the spec, as implementing the spec got very confusing. It is an initial attempt to get some kind of navigation working, and it also includes a simple test for the API.
domenic
reviewed
Jul 10, 2017
There was a problem hiding this comment.
Lots of potential tests to enable or find out why they're not working here:
- https://github.com/w3c/web-platform-tests/tree/master/html/semantics/forms/the-form-element form-action-*
- https://github.com/w3c/web-platform-tests/tree/master/html/browsers/browsing-the-web/navigating-across-documents navigation-unload-form-submit
- https://github.com/w3c/web-platform-tests/tree/master/html/semantics/forms/form-submission-0
| notImplemented("url scheme " + scheme, window); | ||
| } | ||
| // https://html.spec.whatwg.org/#submit-mutate-action | ||
| function mutateActionURL() { |
There was a problem hiding this comment.
Would be ideal to avoid nested functions where possible, moving these to top-level of the module or class and passing in parameters as appropriate
| } | ||
| } | ||
| _getAttributeForSubmission(name, submitter) { | ||
| return submitter.hasAttribute('form' + name) ? submitter.getAttribute('form' + name) : this.getAttribute(name); |
There was a problem hiding this comment.
Somewhat nicer to write as
const formAttribute = submitter.getAttribute("form" + name);
return formAttribute === null ? this.getAttribute(name) : formAttribute;| @@ -21,6 +21,23 @@ exports.evaluateJavaScriptURL = (window, urlRecord) => { | |||
| return undefined; | |||
| }; | |||
|
|
|||
| // https://html.spec.whatwg.org/#the-rules-for-choosing-a-browsing-context-given-a-browsing-context-name | |||
| exports.chooseBrowsingContext = (currentWindow, name) => { | |||
There was a problem hiding this comment.
Can we use this in navigation from a elements too?
| @@ -7,6 +7,12 @@ const { domSymbolTree } = require("../helpers/internal-constants"); | |||
| const createHTMLCollection = require("../../living/html-collection").create; | |||
| const notImplemented = require("../../browser/not-implemented"); | |||
| const { reflectURLAttribute } = require("../../utils"); | |||
| const { constructTheFormDataSet } = require("../xhr/FormData-impl"); | |||
There was a problem hiding this comment.
Ideally let's move this to ../xhr/helpers/formdata.js or similar (i.e. -impl classes should not generally contain helper utilities)
| const form = this; | ||
| const document = this._ownerDocument; | ||
| const window = document._defaultView; | ||
|
|
There was a problem hiding this comment.
Check for a browsing context by checking if window is truthy.
|
|
||
| if (!flags.submittedFromSubmit) { | ||
| const ev = document.createEvent("HTMLEvents"); | ||
| ev.initEvent("submit", true, true); |
There was a problem hiding this comment.
The modern way to do this is
const ev = Event.createImpl(["submit", { bubbles: true, cancelable: true }], {});
|
Wow this is an oldy, what is the status? any way I can help out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support navigation triggered by forms. At the moment, this is only for when the method is “get”. I think implementing “post” is fairly high priority, but “dialog” is less urgent.