Replace runVMScript() with getInternalVMContext() #2768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows more flexibility for vm-using consumers. Closes #2731.
TimothyGu
approved these changes
Jan 1, 2020
ExE-Boss
reviewed
Jan 2, 2020
Comment on lines
+332
to
+334
| script.runInContext(vmContext); | ||
| script.runInContext(vmContext); | ||
| script.runInContext(vmContext); |
There was a problem hiding this comment.
Actually, the variable is named s instead of script.
There was a problem hiding this comment.
Sigh, thanks. I'll do a force-push.
|
Just to follow up, this was a great call rather than messing with the So exposing the context directly was the correct call without jsdom having to add a bunch of extra apis/abstractions 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows more flexibility for vm-using consumers. Closes #2731.
@SimenB please take a look and let me know what you think!