update wpt #2951

zjffun · 2020-04-20T12:52:45Z

remove assert_throws
fix connect ECONNREFUSED
update to-run.yaml
fix or triage TempUnknown in to-run.yaml

zjffun · 2020-04-25T12:46:24Z

I write a script to auto update to-run.yaml, but not sure if this project need. Array of yaml can fold and unfold, this's very convenient, and sort tests can be done automatically.

This update bring about one hundred fail, I only found out a few reasons of them.

domenic · 2020-04-25T20:40:55Z

Please revert the dramatic formatting changes to to-run.yml! The file is intended to be a flat list.

domenic · 2020-04-25T21:21:36Z

I pushed a commit which undoes the dramatic reformatting of to-run.yaml and goes through and updates it for a few cases. It still needs more updates, but hopefully you, or another project contributor, can do that without destroying the readability and editability of the file.

lib/jsdom/living/traversal/NodeFilter-impl.js

zjffun · 2020-04-27T00:28:14Z

@TimothyGu Sorry, I push this file by accident thank you for reminding.

test/web-platform-tests/to-run.yaml

domenic · 2020-05-01T17:37:51Z

Thanks very much for all your hard work here @zjffun. It looks like you're almost done. Let us know if we can help.

TimothyGu

If you could mark this as fixing #2935, that would be super helpful.

...m-tests/to-upstream/html/semantics/forms/the-label-element/clicking-interactive-content.html

zjffun

I misunderstood before, not all elements has activation behavior are interactive content. like HTMLAreaElement

zjffun · 2020-05-02T06:36:37Z

My pleasure. There is a question need help :

I write a small script, it's not good and only work in current to-run-yaml construction. I wender if this script needed, or change to using yaml AST to generate to-run-yaml (current used js-yaml can't support this, may need import an other package).
https://github.com/zjffun/jsdom/blob/rm-assert-throw/test/web-platform-tests/tools/update-to-run.js

lib/jsdom/living/nodes/HTMLAnchorElement-impl.js

lib/jsdom/living/nodes/HTMLImageElement.webidl

lib/jsdom/living/helpers/cors-settings.js

lib/jsdom/living/nodes/HTMLInputElement-impl.js

lib/jsdom/living/nodes/HTMLAnchorElement-impl.js

lib/jsdom/living/nodes/HTMLAreaElement-impl.js

lib/jsdom/living/nodes/HTMLButtonElement-impl.js

lib/jsdom/living/nodes/HTMLElement-impl.js

TimothyGu · 2020-05-03T02:42:26Z

lib/jsdom/living/nodes/HTMLElement-impl.js

@@ -37,10 +39,11 @@ class HTMLElementImpl extends ElementImpl {
  // https://html.spec.whatwg.org/multipage/dom.html#the-translate-attribute
  get translate() {
    const translateAttr = this.getAttributeNS(null, "translate");
+    const translateAttrString = asciiLowercase(translateAttr || "");


How about an early return here if (translateAttr === null). This way we can avoid the awkward check below.

This seems want to do the things in the table below. I can't think a better implementation. @domenic

translateAttr null '' 'yes' 'no' 'gibberish'

asciiLowercase '' '' 'yes' 'no' 'gibberish'

return the logic behind true true false the logic behind

lib/jsdom/living/nodes/HTMLLabelElement-impl.js

zjffun · 2020-05-04T13:39:00Z

It's weird that tabindex-focus-flag.html was taged fail in to-run.yaml https://github.com/zjffun/jsdom/blob/rm-assert-throw/test/web-platform-tests/to-run.yaml#L488, but failing in tarvis at window.add_completion_callback (test/web-platform-tests/run-single-wpt.js:197:22). And I can't reporduct it on my computer.

TimothyGu

Thanks again for all your work. I'd be happy to take this forward and fix the rest of the issues, which are primarily stylistic.

TimothyGu · 2020-05-04T16:28:38Z

lib/jsdom/living/nodes/HTMLAnchorElement-impl.js

  }

+  set _hasActivationBehavior(v) {}


Is the setter necessary?

Remove those two setters will cause error, becauce the parent class HTMLElement need set _hasActivationBehavior and code within the class body's syntactic boundary is always executed in strict mode.
https://github.com/zjffun/jsdom/blob/rm-assert-throw/lib/jsdom/living/nodes/HTMLElement-impl.js#L23

TimothyGu · 2020-05-04T16:28:49Z

lib/jsdom/living/nodes/HTMLInputElement-impl.js

  }

+  set _hasActivationBehavior(v) {}


Is the setter necessary?

TimothyGu · 2020-05-04T16:35:37Z

test/web-platform-tests/tools/update-to-run.js

+
+function resolveWpt(...paths) {
+  return path.resolve(__dirname, "../", ...paths);
+}


This looks somewhat useful, but it doesn't look like the result is being used in this PR. Is my understanding correct?

Dealing with all the TempUnknown and delete a few lines of this script's result is the current to-run.yaml.
Emm.. This script can get all fail tests that not in to-run.yaml, and add them in the right place of to-run.yaml with TempUnknown as reason.

lib/jsdom/living/helpers/cors-settings.js

scripts/webidl/convert.js

TimothyGu · 2020-05-04T16:54:46Z

It's weird that tabindex-focus-flag.html was taged fail in to-run.yaml https://github.com/zjffun/jsdom/blob/rm-assert-throw/test/web-platform-tests/to-run.yaml#L488, but failing in tarvis at window.add_completion_callback (test/web-platform-tests/run-single-wpt.js:197:22). And I can't reporduct it on my computer.

The tabindex-focus-flag.html test was fixed in be0059f. Could you try rebasing your branch onto master?

zjffun · 2020-05-08T11:45:28Z

test/web-platform-tests/to-run.yaml

@@ -476,12 +485,14 @@ sequential-focus-navigation-and-the-tabindex-attribute/focus-tabindex-negative.h
 sequential-focus-navigation-and-the-tabindex-attribute/focus-tabindex-order.html: [fail, scrollIntoView() not implemented]
 sequential-focus-navigation-and-the-tabindex-attribute/focus-tabindex-positive.html: [fail, scrollIntoView() not implemented]
 sequential-focus-navigation-and-the-tabindex-attribute/focus-tabindex-zero.html: [fail, scrollIntoView() not implemented]
+tabindex-focus-flag.html: [fail, https://github.com/jsdom/jsdom/pull/2965]


test/web-platform-tests/tools/update-to-run.js

zjffun · 2020-06-21T16:36:49Z

Thanks everyone for the review. I reorganized commits of this pr, if there is anything else I need to do please @ me.

zjffun · 2020-07-04T11:31:53Z

I self reviewed this PR and found that it was messy and had some errors, so I split them into separate branches. This PR only keeps the changes of update wpt.

In this PR the merged test cases are deleted, and the test under the html/canvas folder is set to require canvas.

Some failed tests cannot be expressed using wildcards, because some of them will pass even if they are not implemented. Like elementFromPoint-parameters.html and image-loading-eager.html.

Some fixes for the new test cases:

translate-enumerated-ascii-case-insensitive.html: https://github.com/zjffun/jsdom/commits/fix/ascii-case-insensitivity
tabindex-focus-flag.html: Treat SVG a element with the href attribute as focusable #2965
radio-valueMissing.html: https://github.com/zjffun/jsdom/commits/fix/radio-value-missing
script-crossorigin-network.sub.html: fix https://github.com/zjffun/jsdom/commits/feature/crossorigin-attr
2d.drawImage.canvas.html: fix(canvas): support drawing an empty canvas into other canvas #2948

domenic · 2020-07-04T17:31:19Z

This is amazing; thank you very much. I appreciate the splitting; that definitely will make things easier. I'll get this merged now and then we can proceed with the other PRs and branches.

domenic · 2020-07-04T17:34:28Z

I noticed a few of the deleted files are not landed in web platform tests upstream. I will un-delete them.

zjffun force-pushed the rm-assert-throw branch 3 times, most recently from f906e93 to b645484 Compare April 25, 2020 12:30

zjffun changed the title ~~[WIP] update wpt~~ update wpt Apr 25, 2020

domenic force-pushed the rm-assert-throw branch from 89bb4b0 to d5b4fcb Compare April 25, 2020 21:30

TimothyGu requested changes Apr 26, 2020

View reviewed changes

lib/jsdom/living/traversal/NodeFilter-impl.js Outdated Show resolved Hide resolved

domenic reviewed May 1, 2020

View reviewed changes

test/web-platform-tests/to-run.yaml Outdated Show resolved Hide resolved

TimothyGu reviewed May 1, 2020

View reviewed changes

...m-tests/to-upstream/html/semantics/forms/the-label-element/clicking-interactive-content.html Outdated Show resolved Hide resolved

zjffun commented May 2, 2020

View reviewed changes

TimothyGu reviewed May 3, 2020

View reviewed changes

lib/jsdom/living/nodes/HTMLAnchorElement-impl.js Outdated Show resolved Hide resolved

TimothyGu reviewed May 3, 2020

View reviewed changes

lib/jsdom/living/nodes/HTMLImageElement.webidl Outdated Show resolved Hide resolved

lib/jsdom/living/helpers/cors-settings.js Outdated Show resolved Hide resolved

lib/jsdom/living/nodes/HTMLInputElement-impl.js Outdated Show resolved Hide resolved

TimothyGu reviewed May 3, 2020

View reviewed changes

TimothyGu reviewed May 4, 2020

View reviewed changes

zjffun force-pushed the rm-assert-throw branch 4 times, most recently from 72e688b to 1eaf549 Compare May 8, 2020 11:07

zjffun commented May 8, 2020

View reviewed changes

ExE-Boss suggested changes May 15, 2020

View reviewed changes

test/web-platform-tests/tools/update-to-run.js Outdated Show resolved Hide resolved

zjffun force-pushed the rm-assert-throw branch 2 times, most recently from 8e26a1a to 19d4b23 Compare June 21, 2020 16:20

update wpt

2c11af0

zjffun force-pushed the rm-assert-throw branch from 19d4b23 to 2c11af0 Compare July 4, 2020 11:23

domenic approved these changes Jul 4, 2020

View reviewed changes

Fixups

b1def36

domenic self-assigned this Jul 4, 2020

domenic merged commit caefe0f into jsdom:master Jul 4, 2020

trueadm mentioned this pull request Jul 5, 2020

Ensure focusin/focusout fires with .focus()/.blur() #2996

Merged

zjffun deleted the rm-assert-throw branch July 12, 2020 08:54

This was referenced Jul 18, 2020

fix: translate, draggable, and type ASCII case insensitivity. #3011

Merged

Fix the valueMissing check of radio #3012

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update wpt #2951

update wpt #2951

zjffun commented Apr 20, 2020 •

edited

zjffun commented Apr 25, 2020

domenic commented Apr 25, 2020 •

edited

domenic commented Apr 25, 2020

zjffun commented Apr 27, 2020 •

edited

domenic commented May 1, 2020

TimothyGu left a comment

zjffun left a comment

zjffun commented May 2, 2020

TimothyGu May 3, 2020

zjffun May 3, 2020

zjffun commented May 4, 2020

TimothyGu left a comment

TimothyGu May 4, 2020

zjffun May 5, 2020 •

edited

TimothyGu May 4, 2020

TimothyGu May 4, 2020

zjffun May 5, 2020

TimothyGu commented May 4, 2020

zjffun May 8, 2020

zjffun commented Jun 21, 2020

zjffun commented Jul 4, 2020

domenic commented Jul 4, 2020

domenic commented Jul 4, 2020


translateAttr	null	''	'yes'	'no'	'gibberish'
asciiLowercase	''	''	'yes'	'no'	'gibberish'
return	the logic behind	true	true	false	the logic behind

update wpt #2951

update wpt #2951

Conversation

zjffun commented Apr 20, 2020 • edited

zjffun commented Apr 25, 2020

domenic commented Apr 25, 2020 • edited

domenic commented Apr 25, 2020

zjffun commented Apr 27, 2020 • edited

domenic commented May 1, 2020

TimothyGu left a comment

Choose a reason for hiding this comment

zjffun left a comment

Choose a reason for hiding this comment

zjffun commented May 2, 2020

TimothyGu May 3, 2020

Choose a reason for hiding this comment

zjffun May 3, 2020

Choose a reason for hiding this comment

zjffun commented May 4, 2020

TimothyGu left a comment

Choose a reason for hiding this comment

TimothyGu May 4, 2020

Choose a reason for hiding this comment

zjffun May 5, 2020 • edited

Choose a reason for hiding this comment

TimothyGu May 4, 2020

Choose a reason for hiding this comment

TimothyGu May 4, 2020

Choose a reason for hiding this comment

zjffun May 5, 2020

Choose a reason for hiding this comment

TimothyGu commented May 4, 2020

zjffun May 8, 2020

Choose a reason for hiding this comment

zjffun commented Jun 21, 2020

zjffun commented Jul 4, 2020

domenic commented Jul 4, 2020

domenic commented Jul 4, 2020

zjffun commented Apr 20, 2020 •

edited

domenic commented Apr 25, 2020 •

edited

zjffun commented Apr 27, 2020 •

edited

zjffun May 5, 2020 •

edited