Fix MutationObserver infinite loop bugs #3173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sebmaster
approved these changes
Apr 9, 2021
|
Great catch, thank you. But we really should have a test :) |
|
Working on it :) |
TimothyGu
force-pushed
the
mutation-disconnect
branch
from
a14fdb9
to
89ac228
Compare
The code was misindented relative to the spec. Fixes jsdom#3096. Fixes jsdom#3172.
TimothyGu
force-pushed
the
mutation-disconnect
branch
from
89ac228
to
a6a6f0f
Compare
domenic
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was misindented relative to the spec.
Fixes #3096. Fixes #3172.