Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly pass null exception to error handlers #3185

Merged
merged 5 commits into from
May 22, 2021
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/jsdom/living/helpers/runtime-script-errors.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ module.exports = function reportException(window, error, filenameHint) {

const windowImpl = idlUtils.implForWrapper(window);

const handled = reportAnError(lineNumber, columnNumber, windowImpl, error, error.message, fileName);
const handled = reportAnError(lineNumber, columnNumber, windowImpl, error, error && error.message, fileName);

if (!handled) {
const errorString = shouldBeDisplayedAsError(error) ? `[${error.name}: ${error.message}]` : util.inspect(error);
Expand All @@ -68,5 +68,5 @@ module.exports = function reportException(window, error, filenameHint) {
};

function shouldBeDisplayedAsError(x) {
return x.name && x.message !== undefined && x.stack;
return x && x.name && x.message !== undefined && x.stack;
}
17 changes: 17 additions & 0 deletions test/api/jsdom-errors.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,21 @@ describe("API: virtual console jsdomErrors", () => {

assert.isEmpty(errors);
});

it("should emit unhandled null value thrown in inline event handlers", t => {
const virtualConsole = new VirtualConsole();
virtualConsole.on("jsdomError", error => {
assert.ok(error instanceof Error);
assert.equal(error.message, "Uncaught null");
assert.isNull(error.detail);
t.done();
});

const html = `<body onclick="throw null"></body>`;
const doc = (new JSDOM(html, { virtualConsole, runScripts: "dangerously" })).window.document;

doc.body.click();
}, {
async: true
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
<!DOCTYPE html>
<meta charset="UTF-8">
<title>Throwing in event listeners</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<div id="log"></div>
<script>
"use strict";

setup({ allow_uncaught_exception: true });

test(() => {
let errorEvents = 0;
document.defaultView.addEventListener("error", event => {
mbest marked this conversation as resolved.
Show resolved Hide resolved
assert_equals(event.message, null);
assert_equals(event.error, null);
++errorEvents;
});

const element = document.createElement("div");

element.addEventListener("click", () => {
throw null; // eslint-disable-line no-throw-literal
});

element.dispatchEvent(new Event("click"));

assert_equals(errorEvents, 1);
}, "Throwing null in event listener");
</script>
mbest marked this conversation as resolved.
Show resolved Hide resolved