Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement async iterables #224
Implement async iterables #224
Changes from 6 commits
394ea8b
204e64a
880bea6
79fb6d6
b049ea6
e3929db
4ade432
d22809e
da811c0
93e7985
c2969ba
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, while at the time I thought having an external attribute would be cleaner, I now see that it makes it inconsistent with
utils.asyncIteratorInit
. I'm open to either this or havereturn
added in the generated file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by "have return added in the generated file"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant essentially the other option you provided, which is using
utils.asyncIteratorReturn in Impl.prototype
to see if we need to add areturn
method to the prototype. But this looks good too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that works because we only require the
Impl
class at the bottom of the file, I think for circular dependency reasons. At which time theimplementation
export might not exist.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question:
ongoingPromise
is only set tonull
if the promisenext()
returns gets fulfilled, not when it gets rejected. It seems to me that we might want the[asyncIteratorReturn]
method to still be called (which probably cleans up some system resources) even if the lastnext()
failed…?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I added a test to the streams WPT to catch this, and will send a Web IDL PR to fix it.