Add Jest-based snapshot testing and Travis #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
force-pushed
the
jest-snapshotting
branch
2 times, most recently
from
fbecf90
to
2551c32
Compare
TimothyGu
approved these changes
May 6, 2017
Sebmaster
reviewed
May 6, 2017
.travis.yml
Outdated
| on_failure: always | ||
|
|
||
| script: | ||
| - npm test |
There was a problem hiding this comment.
That should be the default so not needed.
There was a problem hiding this comment.
Yeah I guess I was copying it from somewhere where we also had npm run lint
TimothyGu
reviewed
May 6, 2017
|
|
||
| branches: | ||
| only: | ||
| - master |
There was a problem hiding this comment.
This shouldn't be needed either. It's not the default but I don't think it's necessary.
There was a problem hiding this comment.
It should reduce the double travis-build in PRs on direct branches.
Previously we were just kind of running test/test.js as needed and hoping for the best. With this in place we have an easier way of checking for regressions.
stevedorries
pushed a commit
to stevedorries/webidl2js
that referenced
this pull request
Jan 27, 2020
stevedorries
pushed a commit
to stevedorries/webidl2js
that referenced
this pull request
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were just kind of running test/test.js as needed and hoping for the best. With this in place we have an easier way of checking for regressions.
Let's get Travis running on the PR first...