Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimal implementation to HTMLElement interface #44

Closed
wants to merge 1 commit into from
Closed

Minimal implementation to HTMLElement interface #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion lib/constructs/interface.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,22 @@ Interface.prototype.generateConstructor = function () {
const passArgs = conversions.hasArgs ? ", args" : "";
this.str += `
iface.setup(this${passArgs});
}\n`;
} else if (this.name === 'HTMLElement') {
this.str += `function ${this.name}() {
const { document, customElements } = global.window;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chrome will auto-detect the environment; I don't know how to do this in jsdom. I'm cheating and using global.window which would be set like global.window = jsdomInstance.window. This is really bad and I want to have it infer directly from jsdom.

This is required since you cannot call new on a subclassed HTMLElement that has not been registered with the active CustomElementsRegistry.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I've run into this myself. I ended up having to add so much crap to simulate the window object I created its own module and would pull it in as a dependency

const ownerDocument = window.document[impl];
let localName = null;
customElements[registry].forEach((Ctor, tagName) => {
if (this.constructor = Ctor) {
localName = tagName;
}
});
module.exports.setup(this, arguments, { localName, ownerDocument });
}\n`;
} else {
this.str += `function ${this.name}() {
throw new TypeError("Illegal constructor");
throw new TypeError('lol this is the DOM not JavaScript ya dummy');
}\n`;
}

Expand All @@ -132,6 +144,10 @@ Interface.prototype.generateRequires = function () {

requireStr += `const impl = utils.implSymbol;\n`;

if (this.name === 'HTMLElement') {
requireStr += `const registry = utils.registrySymbol;\n`;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used by the changes I've made in jsdom core.

}

if (this.mixins.length !== 0) {
requireStr += `const mixin = utils.mixin;\n`;
for (let i = 0; i < this.mixins.length; ++i) {
Expand Down