File URLs test #60
Merged
File URLs test #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This passes if we replace shortenPath with Edit: diagnosed this; updated commit contains a fix and explains the situation. |
domenic
added a commit
to whatwg/url
that referenced
this pull request
Dec 19, 2016
Sometimes "single" is used to mean "any" which causes a different, incorrect interpretation of this algorithm (see jsdom/whatwg-url#60). Clarify by using a more precise algorithm.
This regressed in 8849b62 due to an incorrect interpretation of "shorten the path"; see whatwg/url#174.
domenic
force-pushed
the
fix-file-urls
branch
from
1201b01
to
e7fe858
Compare
annevk
pushed a commit
to whatwg/url
that referenced
this pull request
Dec 19, 2016
Sometimes "single" is used to mean "any" which causes a different, incorrect interpretation of this algorithm (see jsdom/whatwg-url#60). Clarify by using a more precise algorithm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows file URLs seem to have regressed between whatwg-url 3.1.0 and 4.1.0, at least according to jsdom test results. Very strangely no such tests are included upstream.