fixing defaults and optionals on selectors for config flow #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eidl/hass-magic_areas into hotfix/config-flow-selectors-optional
github-actions
bot
force-pushed
the
hotfix/config-flow-selectors-optional
branch
from
0e5c1b7
to
f707358
Compare
…eidl/hass-magic_areas into hotfix/config-flow-selectors-optional
jseidl
added a commit
that referenced
this pull request
Jul 24, 2022
* fixing defaults and optionals on selectors for config flow * fixing defaults and optionals on selectors for config flow * removing commented and debug code * removed duplicate NullableEntitySelector class code block * fixing defaults not showing up if you had a config previously * fixing defaults not showing up if you had a config previously
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #236. Reworked selectors slightly. Original implementation of selectors in Magic Areas was not very well implemented by me and was ignoring defaults and optionals.
In fact, the
EntitySelectorsdoes not support blank values at all so I had to create a new class extending it and checking if the value is null on validation and just allowing it. Seems to be working fine now.