Makes it "focusable" when in "select" mode #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andypandy
commented
Oct 16, 2015
andypandy
commented
- Adds element to tab index when in "" mode. Adds "on focus" event to trigger showing the dropdown Adds an "un focus" event for if they tab away
Closed
|
This introduces a bug where when you click it also triggers the focus event. It needs to be reverted. Sorry! |
|
Oh whoops, I also missed that behavior. |
|
I tried figuring out getting it to choose w/ stopImmediatePropogation but On Thu, Oct 22, 2015 at 4:48 PM, James Seppi notifications@github.com
|
|
I ended up reverting -- binding to focus has a bunch of weird side effects that are hard to properly deal with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.