Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse the TFERACTION element #109

Merged
merged 1 commit into from
Nov 12, 2016
Merged

Conversation

egh
Copy link
Contributor

@egh egh commented Aug 1, 2016

Can be "in" or "out". None if not provided.

Can be `"in"` or `"out"`. `None` if not provided.
@jseutter
Copy link
Owner

Thank you for making this fix. Merging..

@jseutter jseutter merged commit 94fd77d into jseutter:master Nov 12, 2016
@egh
Copy link
Contributor Author

egh commented Nov 12, 2016

Thanks!

@jseutter
Copy link
Owner

Hey, the test you added fails because it expects the tferaction to be "IN", in uppercase. Your ofxparse code, however, does a lower() on the value during the parsing stage. Do you think this lower() call is needed?

The rest of the library generally stays away from modifying the incoming data. Exceptions exist, for example, when doing comparisons to properly discern the message type.

@egh
Copy link
Contributor Author

egh commented Nov 12, 2016

Whoops! Sorry.

If ofxparse generally doesn't modify the data, then I think this should do the same. Should I file a PR?

@jseutter
Copy link
Owner

I can do it, just wanted to check with you to see if I was going to break a program of yours. :)

@egh
Copy link
Contributor Author

egh commented Nov 13, 2016

Thanks for the heads up! I'm not using it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants